• Joined on 2025-04-05
lentil suggested changes for lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

Nicely done! I find it very rewarding that my code was written and structured well enough to enable these extensions. I commented on a few minor points.

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

Seems like we should probably return an error to the caller in this case?

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

Maybe this belongs in the Lossy class itself?

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

I wonder if this is safe -- maybe if no values are found the result should be omitted

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

Comment is outdated, this seems to use a more robust tie breaking algorithm, not relying on processing order

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

This condition means the subsequent test of depth will always pass, regardless of actual depth

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

This line appears to do nothing

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

It looks like CommonSchemas is only used in __tests__ and should probably be moved there

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

and un-negations

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

This line appears to do nothing

lentil pushed to main at lentil/rhizome-network 2025-04-13 22:03:28 -05:00
198cb0853d Readme formatting
lentil pushed to main at lentil/rhizome-network 2025-04-13 21:57:53 -05:00
a82315c5f1 algorithm comments
lentil pushed to main at lentil/rhizome-network 2025-04-13 17:40:34 -05:00
6ec374ec90 remove trailing line break
lentil pushed to main at lentil/rhizome-network 2025-04-13 17:36:15 -05:00
0a43857605 remove trailing line break
lentil pushed to main at lentil/rhizome-network 2025-04-13 17:34:46 -05:00
f0c4efad40 remove a trailing space
lentil pushed to main at lentil/rhizome-network 2025-04-13 17:29:19 -05:00
90d898fd42 initial thoughts
lentil created repository lentil/rhizome-network 2025-04-13 17:22:24 -05:00
lentil pushed to main at lentil/rhizome-node 2025-04-05 23:42:23 -05:00
b5e1acf4e3 minor stuff
f1fcd97fe2 clarify type name
6e0dccdfea refactored collection into abstract and basic in preparation for adding relational
c6f6ece504 refactoring in preparation for adding more resolvers
e684eac932 indentation
Compare 10 commits »
lentil created branch main in lentil/rhizome-node 2025-04-05 23:42:23 -05:00
lentil renamed repository from rhizome to lentil/rhizome-node 2025-04-05 23:40:33 -05:00