major changes and feature additions #1
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "claude_code_work"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR represents a day's work with Claude Code. See todo.md for a list of features added. Additionally some paradigm shifts were integrated, and the filesystem was reorganized. This is too big to properly review but I figure it'd be helpful to treat it as a PR rather than just pushing to master.
Nicely done! I find it very rewarding that my code was written and structured well enough to enable these extensions. I commented on a few minor points.
@ -0,0 +1,247 @@import * as _RhizomeImports from "../src";This line appears to do nothing
@ -0,0 +58,4 @@const result = resolver.resolve();expect(result).toBeDefined();// Should resolve deterministically (likely based on delta processing order)Comment is outdated, this seems to use a more robust tie breaking algorithm, not relying on processing order
@ -0,0 +1,492 @@import * as _RhizomeImports from "../src";This line appears to do nothing
@ -0,0 +443,4 @@expect(stats.negationDeltas).toBe(0); // No negations for this entity});it('should handle multiple negations and un-negations', () => {I'm not seeing anything implementing or testing the negation of a negation
@ -0,0 +251,4 @@while (currentView.nestedObjects.next && currentView.nestedObjects.next.length > 0) {currentView = currentView.nestedObjects.next[0];depth++;if (depth >= 5) break; // Prevent infinite loopThis condition means the subsequent test of depth will always pass, regardless of actual depth
@ -4,0 +337,4 @@'invalid-operator': [{ 'var': 'age' }, 25]});// Should not crash, may return empty results or skip problematic entitiesSeems like we should probably return an error to the caller in this case?
@ -0,0 +1,501 @@import * as _RhizomeImports from "../src";This line appears to do nothing
@ -0,0 +1 @@MANIFEST-000030I think
data/should probably be excluded from the repo by.gitignore@ -0,0 +124,4 @@const entity = this.lossless.domainEntities.get(entityId);if (!entity) continue;// Check if entity has deltas for any required propertyMaybe this should only include items with all required properties?
@ -0,0 +249,4 @@}/*** Extract reference value (target ID) from a delta for a given propertyIt seems like a bug that
propertyIdis not referenced in this function@ -0,0 +199,4 @@}// Common schema patternsexport const CommonSchemas = {It looks like
CommonSchemasis only used in__tests__and should probably be moved there@ -0,0 +270,4 @@}resolve(state: { min?: number }): PropertyTypes {return state.min || 0;I wonder if this is safe -- maybe if no values are found the result should be omitted
@ -0,0 +106,4 @@return res;};// Override resolve to build accumulator on-demand if neededMaybe this belongs in the
Lossyclass itself?I resolved all my own feedback from this PR on branch pr-1-feedback. I'll merge this PR and open a new one.