• Joined on 2025-04-05
lentil pushed to pr-1-feedback at lentil/rhizome-node 2025-06-15 13:17:30 -05:00
99980a31d1 feat(query): validate JSON Logic operators and improve error handling
lentil pushed to pr-1-feedback at lentil/rhizome-node 2025-06-15 13:06:59 -05:00
43b8b9db90 feat: handle undefined values in custom resolvers
ba528e477f chore: remove unused _RhizomeImports from test files
276d2feddb refactor: move common resolve logic to base Lossy class
3888bac91e Fix recursion depth test validity
9e3884d90e refactor: move CommonSchemas to test-utils
Compare 6 commits »
lentil pushed to pr-1-feedback at lentil/rhizome-node 2025-06-15 12:06:28 -05:00
50a822aa0c Entity conforms to schema if it has all required properties, not just some
lentil created branch pr-1-feedback in lentil/rhizome-node 2025-06-15 11:19:16 -05:00
lentil pushed to pr-1-feedback at lentil/rhizome-node 2025-06-15 11:19:16 -05:00
497feb35f9 removed data/ and test-data/ from repo
bb0b415e21 Merge branch 'main' into claude_code_work
Compare 2 commits »
lentil pushed to main at lentil/rhizome-node 2025-06-14 17:05:33 -05:00
cd83f026cd add .env to .gitignore
98014aaa17 add script for generating test coverage report
Compare 2 commits »
lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

This line appears to do nothing

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

and un-negations

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

It looks like CommonSchemas is only used in __tests__ and should probably be moved there

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

This line appears to do nothing

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

This line appears to do nothing

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

I think data/ should probably be excluded from the repo by .gitignore

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

for a given property

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

Maybe this should only include items with all required properties?

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

This condition means the subsequent test of depth will always pass, regardless of actual depth

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

Comment is outdated, this seems to use a more robust tie breaking algorithm, not relying on processing order

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

I wonder if this is safe -- maybe if no values are found the result should be omitted

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

Maybe this belongs in the Lossy class itself?

lentil commented on pull request lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

Seems like we should probably return an error to the caller in this case?

lentil suggested changes for lentil/rhizome-node#1 2025-06-11 13:00:29 -05:00
major changes and feature additions

Nicely done! I find it very rewarding that my code was written and structured well enough to enable these extensions. I commented on a few minor points.