Block a user
major changes and feature additions
It looks like CommonSchemas
is only used in __tests__
and should probably be moved there
major changes and feature additions
I think data/
should probably be excluded from the repo by .gitignore
major changes and feature additions
Maybe this should only include items with all required properties?
major changes and feature additions
This condition means the subsequent test of depth will always pass, regardless of actual depth
major changes and feature additions
Comment is outdated, this seems to use a more robust tie breaking algorithm, not relying on processing order
major changes and feature additions
I wonder if this is safe -- maybe if no values are found the result should be omitted
major changes and feature additions
Seems like we should probably return an error to the caller in this case?
major changes and feature additions
Nicely done! I find it very rewarding that my code was written and structured well enough to enable these extensions. I commented on a few minor points.