Lentil Hoffman d7c4fda93e
refactor(resolver): overhaul plugin system and dependency handling
Core Changes:
- Completely rewrote CustomResolver reducer with dependency-ordered processing
- Enhanced plugin initialization with proper dependency injection
- Improved delta processing and property value tracking
- Added robust error handling for duplicate property IDs

Resolver Improvements:
- Updated to use new accumulator structure
- Implemented execution order processing for plugins
- Enhanced debug logging and error reporting
- Simplified TimestampResolver by removing unused initializer

Configuration Updates:
- Added TypeScript path aliases for test helpers
- Improved module resolution paths

Key Benefits:
- More robust plugin dependency management
- More efficient state updates
- Enhanced type safety
- Better error messages and debugging
- More consistent plugin initialization

This refactoring focuses on improving the robustness of the resolver,
especially around plugin lifecycle management and dependency handling.
The changes ensure better separation of concerns and more predictable
behavior when dealing with complex plugin dependencies.
2025-06-25 06:10:34 -05:00

140 lines
3.8 KiB
TypeScript

import { describe, test, expect, beforeEach } from '@jest/globals';
import { RhizomeNode, Lossless, createDelta, CollapsedDelta } from '@src';
import {
CustomResolver,
ResolverPlugin,
DependencyStates
} from '@src/views/resolvers/custom-resolvers';
import { PropertyTypes } from '@src/core/types';
// A simple plugin for testing lifecycle methods
class LifecycleTestPlugin implements ResolverPlugin<LifecycleTestState> {
readonly dependencies = [] as const;
private initialState: LifecycleTestState = {
initialized: true,
updated: false,
resolved: false
};
initialize(): LifecycleTestState {
return { ...this.initialState };
}
update(
currentState: LifecycleTestState,
_newValue: PropertyTypes,
_delta: CollapsedDelta,
_dependencies: DependencyStates
): LifecycleTestState {
return { ...currentState, updated: true };
}
resolve(
state: LifecycleTestState,
_dependencies: DependencyStates
): PropertyTypes {
// Return a valid PropertyTypes value (string, number, boolean, or null)
// We'll use a JSON string representation of the state
return JSON.stringify({ ...state, resolved: true });
}
}
type LifecycleTestState = {
initialized: boolean;
updated: boolean;
resolved: boolean;
};
describe('Plugin Lifecycle', () => {
let node: RhizomeNode;
let lossless: Lossless;
beforeEach(() => {
node = new RhizomeNode();
lossless = new Lossless(node);
});
test('should call initialize, update, and resolve in order', () => {
// Add some data
lossless.ingestDelta(
createDelta('user1', 'host1')
.withTimestamp(1000)
.setProperty('test1', 'test', 'value1', 'test')
.buildV1()
);
const resolver = new CustomResolver(lossless, {
test: new LifecycleTestPlugin()
});
const results = resolver.resolve() || [];
expect(Array.isArray(results)).toBe(true);
const entity = results.find(r => r.id === 'test1');
expect(entity).toBeDefined();
// Verify all lifecycle methods were called in the correct order
const testProperty = entity?.properties.test;
expect(testProperty).toBeDefined();
// The resolved value should be the return value from resolve() which is a JSON string
const parsed = JSON.parse(testProperty as string);
expect(parsed).toEqual({
initialized: true,
updated: true,
resolved: true
});
});
test('should handle multiple updates correctly', () => {
// First update
lossless.ingestDelta(
createDelta('user1', 'host1')
.withTimestamp(1000)
.setProperty('test2', 'test', 'value1', 'test')
.buildV1()
);
// Second update
lossless.ingestDelta(
createDelta('user1', 'host1')
.withTimestamp(2000)
.setProperty('test2', 'test', 'value2', 'test')
.buildV1()
);
const resolver = new CustomResolver(lossless, {
test: new LifecycleTestPlugin()
});
const results = resolver.resolve() || [];
expect(Array.isArray(results)).toBe(true);
const entity = results.find(r => r.id === 'test2');
expect(entity).toBeDefined();
// Verify state after multiple updates
const testProperty = entity?.properties.test;
expect(testProperty).toBeDefined();
// The resolved value should be the return value from resolve() which is a JSON string
const parsed = JSON.parse(testProperty as string);
expect(parsed).toEqual({
initialized: true,
updated: true, // Should be true from the last update
resolved: true
});
});
test('should handle empty state', () => {
const resolver = new CustomResolver(lossless, {
test: new LifecycleTestPlugin()
});
const results = resolver.resolve();
expect(Array.isArray(results)).toBe(true);
expect(results).toHaveLength(0);
});
});